GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/376
KAFKA-2675; SASL/Kerberos follow up You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka KAFKA-2675-sasl-kerberos-follow-up Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/376.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #376 ---- commit 2e928f4705d731aa2754686651a65b0713d840b8 Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-10-23T08:30:46Z Fix handling of `kafka_jaas.conf` not found in `SaslTestHarness` commit 6aed268b3ff772bebb38c8f242ad63cca6ba83b6 Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-10-23T08:35:29Z Remove unnecessary code in `BaseProducerSendTest` In most cases, `producer` can never be null. In two cases, there are multiple producers and the `var producer` doesn't make sense. commit f0cc13190c0374cf72f76040a52a66bace950ef7 Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-10-23T09:09:05Z Move some tests from `BaseConsumerTest` to `PlaintextConsumerTest` in order to reduce build times commit 8f1aa28fda00820b14f519fd7df457ef7804c634 Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-10-23T09:10:39Z Make `Login` thread a daemon thread This way, it won't prevent shutdown if `close` is not called on `Consumer` or `Producer`. commit f9a3e4e1c918c92771403cabca089092c36c1638 Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-10-23T16:59:43Z Rename `kafka.security.auth.to.local` to `sasl.kerberos.principal.to.local.rules` Also improve wording for `SaslConfigs` docs. commit ac58906f4c446941c43f193aaee45366dfd50950 Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-10-26T09:52:20Z Remove unused `SASL_KAFKA_SERVER_REALM` property commit c68554f4001979ca9283f007e20fe599c1eb85fa Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-10-26T12:59:38Z Remove forced reload of `Configuration` from `Login` and set JAAS property before starting `MiniKdc` commit 503e2662a63bd39a1602ed73cba9b2c8fe4af55f Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-10-27T21:22:59Z Fix `IntegrationTestHarness` to set security configs correctly commit 133076603671c50c4ab820f754c6ebaaedc58f15 Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-10-27T23:27:49Z Improve logging in `ControllerChannelManager` by using `brokerNode` instead of `toBroker` commit 7dd7eeff4748b28f31010196c8fbb2cb65d0da0e Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-10-28T14:36:30Z Introduce `LoginManager.closeAll()` and use it in `SaslTestHarness` This is necessary to avoid authentication failures when consumers, producers or brokers are leaked during tests. commit 0f31db82a07b4be77cd2d95cf9d2f9eecd1343ee Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-10-28T14:37:42Z Improve exception handling in Sasl authenticators: avoid excessive exception chaining ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---