[ 
https://issues.apache.org/jira/browse/KAFKA-2711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982384#comment-14982384
 ] 

ASF GitHub Bot commented on KAFKA-2711:
---------------------------------------

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/390

    KAFKA-2711; SaslClientAuthenticator no longer needs KerberosNameParser in 
constructor

    Also refactor `KerberosNameParser` and `KerberosName` to make the code
    clearer and easier to use when `shortName` is not needed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka kafka-2711

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/390.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #390
    
----
commit 751e52ffee04401a6bf8170469594fe5f526bff1
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2015-10-30T11:13:11Z

    Remove unnecessary usage of `KerberosNameParser` in 
`SaslClientAuthenticator`
    
    Also refactor `KerberosNameParser` and `KerberosName` to make the code
    clearer.

----


> SaslClientAuthenticator no longer needs KerberosNameParser in constructor
> -------------------------------------------------------------------------
>
>                 Key: KAFKA-2711
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2711
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: clients
>    Affects Versions: 0.9.0.0
>            Reporter: Jun Rao
>            Priority: Minor
>             Fix For: 0.9.1
>
>
> Since the sasl client doesn't need to know the principal name, we don't need 
> to pass in KerberosNameParser to SaslClientAuthenticator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to