[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988504#comment-14988504
]
Grant Henke edited comment on KAFKA-2702 at 11/3/15 11:54 PM:
--------------------------------------------------------------
Thanks for all the input [~jkreps], [~gwenshap], [~abiletskyi], [~ijuma],
[~junrao]
I have updated the PR removing the required field and changing all instances of
non-required field to default to null. I also uploaded a v2 sample output to
this jira. Most notably defaults of "" and null are now output and I added a
"valid values" column.
was (Author: granthenke):
Thanks for all the input [~jkreps][~gwenshap][~abiletskyi][~ijuma][~junrao]
I have updated the PR removing the required field and changing all instances of
non-required field to default to null. I also uploaded a v2 sample output to
this jira. Most notably defaults of "" and null are now output and I added a
"valid values" column.
> ConfigDef toHtmlTable() sorts in a way that is a bit confusing
> --------------------------------------------------------------
>
> Key: KAFKA-2702
> URL: https://issues.apache.org/jira/browse/KAFKA-2702
> Project: Kafka
> Issue Type: Bug
> Reporter: Gwen Shapira
> Assignee: Grant Henke
> Attachments: ConsumerConfig-After-v2.html, ConsumerConfig-After.html,
> ConsumerConfig-Before.html
>
>
> Because we put everything without default first (without prioritizing),
> critical parameters get placed below low priority ones when they both have
> no defaults. Some parameters are without default and optional (SASL server in
> ConsumerConfig for instance).
> Try printing ConsumerConfig parameters and see the mandatory group.id show up
> as #15.
> I suggest sorting the no-default parameters by priority as well, or perhaps
> adding a "REQUIRED" category that gets printed first no matter what.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
