[
https://issues.apache.org/jira/browse/KAFKA-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14989137#comment-14989137
]
ASF GitHub Bot commented on KAFKA-2740:
---------------------------------------
Github user miguno closed the pull request at:
https://github.com/apache/kafka/pull/417
> Convert Windows bin scripts from CRLF to LF line encodings
> ----------------------------------------------------------
>
> Key: KAFKA-2740
> URL: https://issues.apache.org/jira/browse/KAFKA-2740
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.8.2.1
> Reporter: Michael Noll
> Priority: Minor
>
> We currently have an inconsistency with regards to line encodings of the
> Windows bin/ scripts. All but three Windows scripts use the same line
> encodings as we do for the rest of the code (LF aka Unix style).
> The three Windows scripts that use CRLF encoding (aka Windows style) are:
> * kafka-run-class.bat
> * kafka-server-stop.bat
> * zookeeper-server-stop.bat
> I'd suggest we convert the three scripts above from CRLF to LF. This will
> not only restore consistency, it will also (and more importantly) resolve
> woes caused by line encoding differences when diffing, patching, etc. these
> files/code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
