[
https://issues.apache.org/jira/browse/KAFKA-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990239#comment-14990239
]
ASF GitHub Bot commented on KAFKA-2744:
---------------------------------------
GitHub user ewencp opened a pull request:
https://github.com/apache/kafka/pull/423
KAFKA-2744: Commit source task offsets after task is completely stopped to
ensure no additional messages are processed during the offset commit when
stopping tasks for rebalancing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ewencp/kafka
commit-source-offsets-after-work-thread-exits
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/423.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #423
----
commit 5c44efa57215153d8d8b3ca6ad50a5f878602f79
Author: Ewen Cheslack-Postava <m...@ewencp.org>
Date: 2015-11-04T05:42:23Z
KAFKA-2744: Commit source task offsets after task is completely stopped to
ensure no additional messages are processed during the offset commit when
stopping tasks for rebalancing.
----
> WorkerSourceTask commits offsets too early when stopping
> --------------------------------------------------------
>
> Key: KAFKA-2744
> URL: https://issues.apache.org/jira/browse/KAFKA-2744
> Project: Kafka
> Issue Type: Bug
> Components: copycat
> Reporter: Ewen Cheslack-Postava
> Assignee: Ewen Cheslack-Postava
> Fix For: 0.9.0.0
>
>
> The call to commit offsets appears ok at first glance because we've invoked
> the SourceTask's stop method, but it runs before we've stopped the work
> thread which could still be invoking the SourceTask's poll() method and may
> have outstanding data. We need to wait until we're sure the work thread has
> completely finished so we're guaranteed to flush all the data generated by
> the SourceTask and commit the final offsets.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
