[ 
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992064#comment-14992064
 ] 

ASF GitHub Bot commented on KAFKA-2702:
---------------------------------------

GitHub user granthenke reopened a pull request:

    https://github.com/apache/kafka/pull/379

    KAFKA-2702: ConfigDef toHtmlTable() sorts in a way that is a bit conf…

    …using

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/granthenke/kafka config-html

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/379.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #379
    
----
commit bc17f6b923f63891c1c36c531b525783df834e42
Author: Grant Henke <granthe...@gmail.com>
Date:   2015-10-29T03:49:24Z

    KAFKA-2702: ConfigDef toHtmlTable() sorts in a way that is a bit confusing

----


> ConfigDef toHtmlTable() sorts in a way that is a bit confusing
> --------------------------------------------------------------
>
>                 Key: KAFKA-2702
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2702
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Gwen Shapira
>            Assignee: Grant Henke
>         Attachments: ConsumerConfig-After-v2.html, ConsumerConfig-After.html, 
> ConsumerConfig-Before.html
>
>
> Because we put everything without default first (without prioritizing), 
> critical  parameters get placed below low priority ones when they both have 
> no defaults. Some parameters are without default and optional (SASL server in 
> ConsumerConfig for instance).
> Try printing ConsumerConfig parameters and see the mandatory group.id show up 
> as #15.
> I suggest sorting the no-default parameters by priority as well, or perhaps 
> adding a "REQUIRED" category that gets printed first no matter what.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to