[
https://issues.apache.org/jira/browse/KAFKA-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992651#comment-14992651
]
ASF GitHub Bot commented on KAFKA-2751:
---------------------------------------
GitHub user lindong28 opened a pull request:
https://github.com/apache/kafka/pull/437
MINOR: KAFKA-2751 Improve documentation for log.retention.ms
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lindong28/kafka KAFKA-2751
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/437.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #437
----
commit ecf417eb443fb5c587810361b7b84368673991f1
Author: Dong Lin <lindon...@gmail.com>
Date: 2015-11-05T22:53:16Z
MINOR: KAFKA-2751 Improve documentation for log.retention.ms
----
> Documentation for retention.ms is confusing
> -------------------------------------------
>
> Key: KAFKA-2751
> URL: https://issues.apache.org/jira/browse/KAFKA-2751
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8.2.1
> Reporter: Craig W
> Assignee: Dong Lin
> Priority: Minor
>
> The documentation for the "retention.ms" setting is a little confusing. When
> looking at the documentation the property is in the first column, while the
> default server property is in the 3rd column which is named
> "log.retention.minutes". The description for the property doesn't describe
> the expected value, so it leads one to believe maybe "retention.ms" is meant
> to be minutes.
> I'd like to see the description for the property explicitly mention that the
> value at the topic level is milliseconds, where as it's minutes for the
> server level.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
