[
https://issues.apache.org/jira/browse/KAFKA-2764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14994252#comment-14994252
]
ASF GitHub Bot commented on KAFKA-2764:
---------------------------------------
GitHub user ewencp opened a pull request:
https://github.com/apache/kafka/pull/444
KAFKA-2764: Change use of Properties in Copycat to Maps.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ewencp/kafka kafka-2764-maps-not-properties
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/444.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #444
----
commit 3fcf148fb97f97722abed6bfbfb29a476e761ae0
Author: Ewen Cheslack-Postava <[email protected]>
Date: 2015-11-06T19:10:17Z
KAFKA-2764: Change use of Properties in Copycat to Maps.
----
> Copycat APIs should use Map<String, String> instead of Properties
> -----------------------------------------------------------------
>
> Key: KAFKA-2764
> URL: https://issues.apache.org/jira/browse/KAFKA-2764
> Project: Kafka
> Issue Type: Bug
> Components: copycat
> Reporter: Ewen Cheslack-Postava
> Assignee: Ewen Cheslack-Postava
> Fix For: 0.9.0.0
>
>
> Properties objects were used elsewhere in Kafka, but the new clients have
> moved to regular maps (Map<String, Object> for most configs, but Map<String,
> String> makes sense for Copycat since the configs the maps are used for
> always have to be serializeable to .properties files). Since Properties
> objects are kind of annoying to deal with and we have a bunch of translations
> scattered throughout the Copycat code, it will be easier to use Maps and only
> resort to using the Properties class for parsing the .properties files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
