[ 
https://issues.apache.org/jira/browse/KAFKA-2805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14999844#comment-14999844
 ] 

Mayuresh Gharat commented on KAFKA-2805:
----------------------------------------

Yes. That was the thinking. Also from the KIP-19 discussion it was decided that 
Request timeout will also be used when the batches in the accumulator that are 
ready but not drained due to metadata missing - we are reusing request timeout 
to timeout the batches in accumulator. When we say metadata is missing, it 
means that we don't have information about the leader.
 

> RecordAccumulator request timeout only enforced if partition leader is unknown
> ------------------------------------------------------------------------------
>
>                 Key: KAFKA-2805
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2805
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Jason Gustafson
>            Assignee: Mayuresh Gharat
>
> From the user mailing list, the null check in batch expiration in 
> RecordAccumulator seems questionable: 
> https://github.com/apache/kafka/blob/ae5a5d7c08bb634576a414f6f2864c5b8a7e58a3/clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java#L220.
>  
> If this is correct behavior, it is probably worthwhile clarifying the purpose 
> of the check in a comment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to