[
https://issues.apache.org/jira/browse/KAFKA-2805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15001495#comment-15001495
]
ASF GitHub Bot commented on KAFKA-2805:
---------------------------------------
GitHub user MayureshGharat opened a pull request:
https://github.com/apache/kafka/pull/503
KAFKA-2805
Removed the check for only those expiring batches whose metadata is
unavailable. Now the batches will be expired irrespective of whether the leader
is available or not, as soon as it reaches the requestimeout threshold.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MayureshGharat/kafka kafka-2805
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/503.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #503
----
commit 573c68b9ee3107a50c96d383e22dd415fc39b96f
Author: Mayuresh Gharat <mgha...@mgharat-ld1.linkedin.biz>
Date: 2015-11-12T01:42:46Z
Removed the check for only those expiring batches whose metadata is
unavailable. Now the batches will be expired irrespective of whether the leader
is available or not, as soon as it reaches the requestimeout threshold
----
> RecordAccumulator request timeout not enforced when all brokers are gone
> ------------------------------------------------------------------------
>
> Key: KAFKA-2805
> URL: https://issues.apache.org/jira/browse/KAFKA-2805
> Project: Kafka
> Issue Type: Bug
> Reporter: Jason Gustafson
> Assignee: Mayuresh Gharat
> Priority: Blocker
> Fix For: 0.9.0.0
>
>
> When no brokers are left in the cluster, the producer seems not to enforce
> the request timeout as expected.
> From the user mailing list, the null check in batch expiration in
> RecordAccumulator seems questionable:
> https://github.com/apache/kafka/blob/ae5a5d7c08bb634576a414f6f2864c5b8a7e58a3/clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java#L220.
>
> If this is correct behavior, it is probably worthwhile clarifying the purpose
> of the check in a comment.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
