[
https://issues.apache.org/jira/browse/KAFKA-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005727#comment-15005727
]
jin xing edited comment on KAFKA-2605 at 11/15/15 5:00 AM:
-----------------------------------------------------------
yes,
"case e:Throwable" is dangerous;
I will make it to be NonFatal
was (Author: [email protected]):
https://issues.apache.org/jira/browse/KAFKA-2605?jql=project%20%3D%20KAFKA%20AND%20status%20%3D%20Open%20AND%20labels%20%3D%20newbie%20AND%20assignee%20in%20(%22jinxing6042%40126.com%22)
> Replace `catch: Throwable` clauses with `NonFatal` or `NonControl`
> ------------------------------------------------------------------
>
> Key: KAFKA-2605
> URL: https://issues.apache.org/jira/browse/KAFKA-2605
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.8.2.2
> Reporter: Ismael Juma
> Assignee: jin xing
> Labels: newbie
>
> The Kafka codebase includes a number of instances where we do `catch t:
> Throwable` where we should really be doing `catch NonFatal(t)` or `catch
> NonControl(t)` where `NonFatal` is part of the standard library and
> `NonControl` is something like:
> {code}
> object NonControl {
> def apply(t: Throwable): Boolean = t match {
> case _: ControlThrowable => false
> case _ => true
> }
> def unapply(t: Throwable): Option[Throwable] = if (apply(t)) Some(t) else
> None
> }
> {code}
> We can also use `NonControl` to replace cases like (it's more concise and has
> the same behaviour):
> {code}
> case e: ControlThrowable => throw e
> case e: Throwable => ...
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
