[ https://issues.apache.org/jira/browse/KAFKA-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011539#comment-15011539 ]
ASF GitHub Bot commented on KAFKA-2858: --------------------------------------- GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/551 KAFKA-2858; Introduce `SimplePrincipal` and use it in the authentication layer This makes it clear that we only support a principal name at the authentication layer (principalType is only used at the authorization layer). You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka kafka-2858-clarify-usage-of-principal Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/551.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #551 ---- commit 8b2715441b444a435cf6cdf3aa641d1ddcbf36f1 Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-11-18T17:41:53Z Introduce `SimplePrincipal` and use it in the authentication layer This makes it clear that we only support a principal name at the authentication layer (principalType is only used at the authorization layer). ---- > Clarify usage of `Principal` in the authentication layer > -------------------------------------------------------- > > Key: KAFKA-2858 > URL: https://issues.apache.org/jira/browse/KAFKA-2858 > Project: Kafka > Issue Type: Improvement > Components: security > Reporter: Ismael Juma > Assignee: Ismael Juma > Priority: Minor > > We currently use `KafkaPrincipal` at the authentication and authorization > layer. But there is an implicit assumption that we always use a > `KafkaPrincipal` with principalType == USER_TYPE as we ignore the the > principalType of the `KafkaPrincipal` when we create `RequestChannel.Session`. > I think it would be clearer if we used a separate `Principal` implementation > in the authentication layer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)