[ https://issues.apache.org/jira/browse/KAFKA-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018891#comment-15018891 ]
ASF GitHub Bot commented on KAFKA-2825: --------------------------------------- GitHub user apovzner opened a pull request: https://github.com/apache/kafka/pull/570 KAFKA-2825, KAFKA-2852: Controller failover tests added to ducktape replication tests and fix to temp dir I closed an original pull request that contained previous comments by Geoff (which are already addressed here), because I got into bad rebase situation. So, I created a new branch and cherry-picked my commits + merged with Ben's changes to fix MiniKDC tests to run on Virtual Box. That change was conflicting with my changes, where I was copying MiniKDC files with new scp method, and temp file was created inside that method. To merge Ben's changes, I added two optional parameters to scp(): 'pattern' and 'subst' to optionally substitute string while spp'ing files, which is needed for krb5.conf file. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apovzner/kafka kafka-2825 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/570.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #570 ---- commit 44f7a6ea9fbfc11e6eebc44b5bfab36431469522 Author: Anna Povzner <a...@confluent.io> Date: 2015-11-11T22:43:49Z Extended existing ducktape replication tests to include controller failover commit 447e330c840e9a556aff2d05d54f873aee8641a5 Author: Anna Povzner <a...@confluent.io> Date: 2015-11-12T04:12:43Z Using random dir under /temp for local kdc files to avoid conflicts. commit a364a3f289277579f17973829a3d51a97749875c Author: Anna Povzner <a...@confluent.io> Date: 2015-11-12T21:40:32Z Fixed usage of random dir under local /tmp for miniKdc files commit 5b2c048d1c0922b8d36286d96c90bae53c01a671 Author: Anna Povzner <a...@confluent.io> Date: 2015-11-12T21:48:47Z Fix to make sure that temp dir for mini kcd files is removed after test finishes. commit 18c8670e18cfdb641efe14df3c2479ba7e340e0d Author: Anna Povzner <a...@confluent.io> Date: 2015-11-17T19:17:05Z KAFKA-2825 Moved query zookeeper method from KafkaService to ZookeeperService commit d70d1eb17fa1ee54dadd52d55ba3e89a81b37c0d Author: Anna Povzner <a...@confluent.io> Date: 2015-11-17T21:54:04Z KAFKA-2851 Added scp method to remote_account utils to scp between two remote nodes through unique local temp file commit 34830cd67e00f7b28d1afcffe9653fc543bca9d0 Author: Anna Povzner <a...@confluent.io> Date: 2015-11-17T21:59:02Z KAFKA-2851: minor fix to format string in utils.remote_coount.scp method commit e5a28e3e2718e057138043a7d6cbc9d42c17d84e Author: Anna Povzner <a...@confluent.io> Date: 2015-11-18T02:56:57Z KAFKA-2851: clean up temp file even if scp fails commit bed5a2f1f75462d857fc44382322544e6adc2bb2 Author: Anna Povzner <a...@confluent.io> Date: 2015-11-18T18:17:09Z KAFKA-2825 Using only PLAINTEXT and SASL_SSL security protocols for controller failover tests commit 84d21b6ac1324f7ac2bbc0f908d7a218e95501d5 Author: Anna Povzner <a...@confluent.io> Date: 2015-11-20T21:49:49Z Merged with Ben's changes to make MiniKFC tests to run on Virtual Box commit f0d630907f4eaf14e7274e9075022d949e5b2752 Author: Anna Povzner <a...@confluent.io> Date: 2015-11-20T21:53:43Z Very minor changes: typo in output string and some white spaces. ---- > Add controller failover to existing replication tests > ----------------------------------------------------- > > Key: KAFKA-2825 > URL: https://issues.apache.org/jira/browse/KAFKA-2825 > Project: Kafka > Issue Type: Test > Reporter: Anna Povzner > Assignee: Anna Povzner > > Extend existing replication tests to include controller failover: > * clean/hard shutdown > * clean/hard bounce -- This message was sent by Atlassian JIRA (v6.3.4#6332)