[
https://issues.apache.org/jira/browse/KAFKA-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058846#comment-15058846
]
ASF GitHub Bot commented on KAFKA-2547:
---------------------------------------
GitHub user Parth-Brahmbhatt opened a pull request:
https://github.com/apache/kafka/pull/679
KAFKA-2547: Make DynamicConfigManager to use the ZkNodeChangeNotifica…
…tionListener introduced as part of KAFKA-2211
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Parth-Brahmbhatt/kafka KAFKA-2547
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/679.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #679
----
commit 10071378d38bab1bcf00aefa0ef678fdb77c8f5b
Author: Parth Brahmbhatt <[email protected]>
Date: 2015-12-15T21:15:22Z
KAFKA-2547: Make DynamicConfigManager to use the
ZkNodeChangeNotificationListener introduced as part of KAFKA-2211
----
> Make DynamicConfigManager to use the ZkNodeChangeNotificationListener
> introduced as part of KAFKA-2211
> ------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-2547
> URL: https://issues.apache.org/jira/browse/KAFKA-2547
> Project: Kafka
> Issue Type: Improvement
> Reporter: Parth Brahmbhatt
> Assignee: Parth Brahmbhatt
>
> As part of KAFKA-2211 (https://github.com/apache/kafka/pull/195/files) we
> introduced a reusable ZkNodeChangeNotificationListener to ensure node changes
> can be processed in a loss less way. This was pretty much the same code in
> DynamicConfigManager with little bit of refactoring so it can be reused. We
> now need to make DynamicConfigManager itself to use this new class once
> KAFKA-2211 is committed to avoid code duplication.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
