[ 
https://issues.apache.org/jira/browse/KAFKA-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063856#comment-15063856
 ] 

ASF GitHub Bot commented on KAFKA-2455:
---------------------------------------

GitHub user ZoneMayor opened a pull request:

    https://github.com/apache/kafka/pull/694

    KAFKA-2455: Test Failure: kafka.consumer.MetricsTest > testMetricsLeak

    @guozhangwang 
    I reproduced this;
    Every time this test failed, I found extra "type=DelayedFetchMetrics, 
name=ExpiresperSec, fetcherType=consumer/follower" inside 
Metrics.defaultRegistry().allMetrics().keySet();
    that is because for "DelayedFetch", object DelayedFetchMetrics are loaded 
dynamically in function "onExpiration";
    To fix, I explicitly load this object;
    Is it appropriate?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ZoneMayor/kafka trunk-KAFKA-2455

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/694.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #694
    
----
commit 34240b52e1b70aa172b65155f6042243d838b420
Author: ZoneMayor <jinxing6...@126.com>
Date:   2015-12-18T07:22:20Z

    Merge pull request #12 from apache/trunk
    
    2015-12-18

commit 5e6284e034fc8e92745f1ebdda2fa228b8beaf4f
Author: jinxing <jinx...@fenbi.com>
Date:   2015-12-18T11:17:17Z

    KAFKA-2455: Test Failure: kafka.consumer.MetricsTest > testMetricsLeak

----


> Test Failure: kafka.consumer.MetricsTest > testMetricsLeak 
> -----------------------------------------------------------
>
>                 Key: KAFKA-2455
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2455
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Gwen Shapira
>
> I've seen this failure in builds twice recently:
> kafka.consumer.MetricsTest > testMetricsLeak FAILED
>     java.lang.AssertionError: expected:<174> but was:<176>
>         at org.junit.Assert.fail(Assert.java:92)
>         at org.junit.Assert.failNotEquals(Assert.java:689)
>         at org.junit.Assert.assertEquals(Assert.java:127)
>         at org.junit.Assert.assertEquals(Assert.java:514)
>         at org.junit.Assert.assertEquals(Assert.java:498)
>         at 
> kafka.consumer.MetricsTest$$anonfun$testMetricsLeak$1.apply$mcVI$sp(MetricsTest.scala:65)
>         at scala.collection.immutable.Range.foreach$mVc$sp(Range.scala:141)
>         at kafka.consumer.MetricsTest.testMetricsLeak(MetricsTest.scala:63)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to