[
https://issues.apache.org/jira/browse/KAFKA-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065697#comment-15065697
]
ASF GitHub Bot commented on KAFKA-3009:
---------------------------------------
GitHub user manasvigupta opened a pull request:
https://github.com/apache/kafka/pull/700
KAFKA-3009 : Disallow star imports
Summary of code changes
------------------------------------
1) Added a new Checkstyle rule to flag any code using star imports
2) Fixed ALL existing code violations using star imports
Testing
-----------
Local build was successful
ALL JUnits ran successfully on local.
@ewencp - Request you to please review changes. Thank you !
I state that the contribution is my original work and I license the work to
the project under the project's open source license.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manasvigupta/kafka KAFKA-3009
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/700.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #700
----
commit fbe5a941a2aefc6507ef4d2eb515f8279d93313b
Author: manasvigupta <manasvigu...@yahoo.co.in>
Date: 2015-12-20T09:40:30Z
code changes to fix issue - KAFKA-3009
----
> Disallow star imports
> ---------------------
>
> Key: KAFKA-3009
> URL: https://issues.apache.org/jira/browse/KAFKA-3009
> Project: Kafka
> Issue Type: Bug
> Reporter: Gwen Shapira
> Assignee: Manasvi Gupta
> Labels: newbie
>
> Looks like we don't want star imports in our code (java.utils.*)
> So, lets add this rule to checkstyle and fix existing violations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
