GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/743
MINOR: Fix bug in `waitUntilLeaderIsElectedOrChanged` and simplify result
type
The bug was for the following case:
`leader.isDefined && oldLeaderOpt.isEmpty && newLeaderOpt.isDefined &&
newLeaderOpt.get != leader.get`
We would consider it a successful election/change even though we should not.
I also changed the result type as we never return `None` (we throw an
exception instead).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka
fix-wait-until-leader-is-elected-or-changed
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/743.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #743
----
commit 4b17f8501d44e3b54dff2b1a4f86673b1e514776
Author: Ismael Juma <[email protected]>
Date: 2016-01-08T16:48:47Z
Fix bug in `waitUntilLeaderIsElectedOrChanged` and simplify result type
The bug was for the following case:
`leader.isDefined && oldLeaderOpt.isEmpty && newLeaderOpt.isDefined &&
newLeaderOpt.get != leader.get`
We would consider it a successful election even though we should not.
I also changed the result type is we never return `None` (we throw an
exception instead).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
