[
https://issues.apache.org/jira/browse/KAFKA-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091671#comment-15091671
]
Raju Bairishetti commented on KAFKA-3087:
-----------------------------------------
Could any one please add me as a contributor?
> Fix documentation for retention.ms property and update documentation for
> LogConfig.scala class
> ----------------------------------------------------------------------------------------------
>
> Key: KAFKA-3087
> URL: https://issues.apache.org/jira/browse/KAFKA-3087
> Project: Kafka
> Issue Type: Bug
> Components: log
> Reporter: Raju Bairishetti
> Assignee: Jay Kreps
> Priority: Critical
> Labels: documentation
>
> Log retention settings can be set it in broker and some properties can be
> overriden at topic level.
> |Property |Default|Server Default property| Description|
> |retention.ms|7 days|log.retention.minutes|This configuration controls the
> maximum time we will retain a log before we will discard old log segments to
> free up space if we are using the "delete" retention policy. This represents
> an SLA on how soon consumers must read their data.|
> But retention.ms is in milli seconds not in minutes. So corresponding
> property should be *log.retention.ms* instead of *log.retention.minutes*.
> It would be better if we mention the if the time age is in
> millis/minutes/hours in the documentation page and documenting in code as
> well (Right now, it is saying *age in the code*. We should specify the *age
> in time granularity).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
