[
https://issues.apache.org/jira/browse/KAFKA-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092874#comment-15092874
]
ASF GitHub Bot commented on KAFKA-3089:
---------------------------------------
GitHub user lindong28 opened a pull request:
https://github.com/apache/kafka/pull/755
KAFKA-3089; VerifiableProducer should do a clean shutdown in stop_node()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lindong28/kafka KAFKA-3089
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/755.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #755
----
commit 1fdf7dc454f17da2f8ca95e62953949bf7cc0e3d
Author: Dong Lin <lindon...@gmail.com>
Date: 2016-01-11T22:36:37Z
KAFKA-3089; VerifiableProducer should do a clean shutdown in stop_node()
----
> VerifiableProducer should do a clean shutdown in stop_node()
> ------------------------------------------------------------
>
> Key: KAFKA-3089
> URL: https://issues.apache.org/jira/browse/KAFKA-3089
> Project: Kafka
> Issue Type: Improvement
> Reporter: Dong Lin
> Assignee: Dong Lin
>
> VerifiableProducer is closed by SIGKILL when stop_node() is called. For this
> reason, when stop_producer_and_consumer() is invoked in
> ProduceConsumeValidateTest, VerifiableProducer is killed immediately without
> allowing it to wait for acknowledgement. The reported number of messages
> produced by VerifiableProducer will thus be much smaller than the reported
> number of messages consumed by consumer, causing confusion to developers.
> For almost all other services, such as VerifiableConsumer and
> ConsoleConsumer, we send SIGINT when stop_node() is called. It is not clear
> why VerifiableProducer is different from them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
