[ 
https://issues.apache.org/jira/browse/KAFKA-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095535#comment-15095535
 ] 

ASF GitHub Bot commented on KAFKA-3012:
---------------------------------------

GitHub user granthenke opened a pull request:

    https://github.com/apache/kafka/pull/762

    KAFKA-3012: Avoid reserved.broker.max.id collisions on upgrade

    Provides a configuration to opt out of broker id generation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/granthenke/kafka id-generation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/762.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #762
    
----
commit c60449ff37664c8f05a9b3faef96b05bcd821c32
Author: Grant Henke <[email protected]>
Date:   2016-01-12T22:59:55Z

    KAFKA-3012: Avoid reserved.broker.max.id collisions on upgrade
    
    Provides a configuration to opt out of broker id generation.

----


> Avoid reserved.broker.max.id collisions on upgrade
> --------------------------------------------------
>
>                 Key: KAFKA-3012
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3012
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.9.0.0
>            Reporter: Grant Henke
>            Assignee: Grant Henke
>
> I have seen a few issues utilizing the default value of 
> reserved.broker.max.id=1000 in existing clusters during upgrades. For many 
> that started broker.ids at 0 and incremented by 1 this may not be an issue. 
> However, others may have very different numbering schemes. 
> Given that we have the entire Integer range to work with, I propose we 
> increase the default to a much larger value. This will help reduce upgrade 
> issues and also help more clearly identify generated broker ids.
> Would defaulting to 1,000,000,000 be to large? Perhaps 1,000,000 is enough.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to