[
https://issues.apache.org/jira/browse/KAFKA-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15103614#comment-15103614
]
ASF GitHub Bot commented on KAFKA-3106:
---------------------------------------
GitHub user ZoneMayor opened a pull request:
https://github.com/apache/kafka/pull/783
KAFKA-3106: Fix updating an existing connector config from REST API, GET a
connector config will fail
When query for connector and task config info by REST API, method of
"checkConfigSynced" will check if herder's config is in sync with the current
config;
But the configState's offset may be bigger than the assignment's offset
after updating an existing connector, because the connector can pick up the
config change without a rebalance;
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ZoneMayor/kafka trunk-KAFKA-3106
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/783.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #783
----
commit 34240b52e1b70aa172b65155f6042243d838b420
Author: ZoneMayor <[email protected]>
Date: 2015-12-18T07:22:20Z
Merge pull request #12 from apache/trunk
2015-12-18
commit 52d02f333e86d06cfa8fff5facd18999b3db6d83
Author: ZoneMayor <[email protected]>
Date: 2015-12-30T03:08:08Z
Merge pull request #13 from apache/trunk
2015-12-30
commit d56be0b9e0849660c07d656c6019f9cc2f17ae55
Author: ZoneMayor <[email protected]>
Date: 2016-01-10T09:24:06Z
Merge pull request #14 from apache/trunk
2016-1-10
commit 9a167901ef32579cfad929ef6dc9ebc7385d18dc
Author: jinxing <[email protected]>
Date: 2016-01-17T06:33:19Z
KAFKA-3106: Fix updating an existing connector config from REST API, GET a
connector config will fail
----
> After PUT a connector config from REST API, GET a connector config will fail
> -----------------------------------------------------------------------------
>
> Key: KAFKA-3106
> URL: https://issues.apache.org/jira/browse/KAFKA-3106
> Project: Kafka
> Issue Type: Bug
> Components: copycat
> Reporter: jin xing
> Assignee: jin xing
>
> If there is already a connector in Connect, and we PUT a connector config by
> REST API, the assignment.offset of DistributedHerder will below the
> configStat.offset, thus GET connector config though REST API will fail
> because of failed to pass "checkConfigSynced";
> The failed message is "Cannot get config data because config is not in sync
> and this is not the leader";
> There need to be a rebalance process for PUT to update the assignment.offset;
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
