[
https://issues.apache.org/jira/browse/KAFKA-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121772#comment-15121772
]
ASF GitHub Bot commented on KAFKA-3068:
---------------------------------------
GitHub user enothereska opened a pull request:
https://github.com/apache/kafka/pull/823
KAFKA-3068: Remove retry with nodesEverSeen
@ewencp @ijuma if this looks good please merge when you can. Thanks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/enothereska/kafka kafka-3068-alt
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/823.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #823
----
commit 820be2808bd7e399d1ecf1b26fb9388783cb3029
Author: Eno Thereska <eno.there...@gmail.com>
Date: 2016-01-28T15:58:31Z
Remove retry with nodesEverSeen
----
> NetworkClient may connect to a different Kafka cluster than originally
> configured
> ---------------------------------------------------------------------------------
>
> Key: KAFKA-3068
> URL: https://issues.apache.org/jira/browse/KAFKA-3068
> Project: Kafka
> Issue Type: Bug
> Components: clients
> Affects Versions: 0.9.0.0
> Reporter: Jun Rao
> Assignee: Eno Thereska
>
> In https://github.com/apache/kafka/pull/290, we added the logic to cache all
> brokers (id and ip) that the client has ever seen. If we can't find an
> available broker from the current Metadata, we will pick a broker that we
> have ever seen (in NetworkClient.leastLoadedNode()).
> One potential problem this logic can introduce is the following. Suppose that
> we have a broker with id 1 in a Kafka cluster. A producer client remembers
> this broker in nodesEverSeen. At some point, we bring down this broker and
> use the host in a different Kafka cluster. Then, the producer client uses
> this broker from nodesEverSeen to refresh metadata. It will find the metadata
> in a different Kafka cluster and start producing data there.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
