[ https://issues.apache.org/jira/browse/KAFKA-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123757#comment-15123757 ]
ASF GitHub Bot commented on KAFKA-3161: --------------------------------------- Github user crhyne closed the pull request at: https://github.com/apache/kafka/pull/824 > Refactor Java client's use of the Properties class > -------------------------------------------------- > > Key: KAFKA-3161 > URL: https://issues.apache.org/jira/browse/KAFKA-3161 > Project: Kafka > Issue Type: Improvement > Components: clients > Affects Versions: 0.9.0.0 > Reporter: Cliff Rhyne > > The KafkaConsumer takes a Properties class for the config, but then instead > of using it's getProperty() function the class gets copied (which breaks the > use of defaults). > One example is this from ConsumerConfig: > Properties newProperties = new Properties(); > newProperties.putAll(properties); > Which could be re-written as: > Properties newProperties = new Properties(properties); > This is important because applications using the client library expect to be > able to specify the default properties above. > (I'm not sure how to go about this, but I'm working on the change locally > right now. I'd like to assign it to myself but I guess I can't because i'm > not on the contributor list). -- This message was sent by Atlassian JIRA (v6.3.4#6332)