[
https://issues.apache.org/jira/browse/KAFKA-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124778#comment-15124778
]
ASF GitHub Bot commented on KAFKA-3174:
---------------------------------------
GitHub user becketqin opened a pull request:
https://github.com/apache/kafka/pull/841
KAFKA-3174: Change Crc32 to use java.util.zip.CRC32
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/becketqin/kafka KAFKA-3174
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/841.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #841
----
commit 4419cb58d84466e36c8b1119704eac93566c9974
Author: Jiangjie Qin <[email protected]>
Date: 2016-01-30T06:44:20Z
Change Crc32 to use java.util.zip.CRC32
----
> Re-evaluate the CRC32 class performance.
> ----------------------------------------
>
> Key: KAFKA-3174
> URL: https://issues.apache.org/jira/browse/KAFKA-3174
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.9.0.0
> Reporter: Jiangjie Qin
> Assignee: Jiangjie Qin
> Fix For: 0.9.0.1
>
>
> We used org.apache.kafka.common.utils.CRC32 in clients because it has better
> performance than java.util.zip.CRC32 in Java 1.6.
> In a recent test I ran it looks in Java 1.8 the CRC32 class is 2x as fast as
> the Crc32 class we are using now. We may want to re-evaluate the performance
> of Crc32 class and see it makes sense to simply use java CRC32 instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
