[
https://issues.apache.org/jira/browse/KAFKA-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132712#comment-15132712
]
ASF GitHub Bot commented on KAFKA-3088:
---------------------------------------
GitHub user granthenke opened a pull request:
https://github.com/apache/kafka/pull/866
KAFKA-3088: broker crash on receipt of produce request with empty cli…
…ent ID
- Adds NULLABLE_STRING Type to the protocol
- Changes client_id in the REQUEST_HEADER to NULLABLE_STRING with a default
of ""
- Fixes server handling of invalid ApiKey request and other invalid requests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/granthenke/kafka null-clientid
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/866.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #866
----
commit b17eb557ac989dfa19d32370eca4cb73eca30664
Author: Grant Henke <granthe...@gmail.com>
Date: 2016-02-04T18:17:51Z
KAFKA-3088: broker crash on receipt of produce request with empty client ID
- Adds NULLABLE_STRING Type to the protocol
- Changes client_id in the REQUEST_HEADER to NULLABLE_STRING with a default
of ""
- Fixes server handling of invalid ApiKey request and other invalid requests
----
> 0.9.0.0 broker crash on receipt of produce request with empty client ID
> -----------------------------------------------------------------------
>
> Key: KAFKA-3088
> URL: https://issues.apache.org/jira/browse/KAFKA-3088
> Project: Kafka
> Issue Type: Bug
> Components: producer
> Affects Versions: 0.9.0.0
> Reporter: Dave Peterson
> Assignee: Grant Henke
> Fix For: 0.9.0.1
>
>
> Sending a produce request with an empty client ID to a 0.9.0.0 broker causes
> the broker to crash as shown below. More details can be found in the
> following email thread:
> http://mail-archives.apache.org/mod_mbox/kafka-users/201601.mbox/%3c5693ecd9.4050...@dspeterson.com%3e
> [2016-01-10 23:03:44,957] ERROR [KafkaApi-3] error when handling request
> Name: ProducerRequest; Version: 0; CorrelationId: 1; ClientId: null;
> RequiredAcks: 1; AckTimeoutMs: 10000 ms; TopicAndPartition: [topic_1,3] -> 37
> (kafka.server.KafkaApis)
> java.lang.NullPointerException
> at
> org.apache.kafka.common.metrics.JmxReporter.getMBeanName(JmxReporter.java:127)
> at
> org.apache.kafka.common.metrics.JmxReporter.addAttribute(JmxReporter.java:106)
> at
> org.apache.kafka.common.metrics.JmxReporter.metricChange(JmxReporter.java:76)
> at
> org.apache.kafka.common.metrics.Metrics.registerMetric(Metrics.java:288)
> at org.apache.kafka.common.metrics.Sensor.add(Sensor.java:177)
> at org.apache.kafka.common.metrics.Sensor.add(Sensor.java:162)
> at
> kafka.server.ClientQuotaManager.getOrCreateQuotaSensors(ClientQuotaManager.scala:209)
> at
> kafka.server.ClientQuotaManager.recordAndMaybeThrottle(ClientQuotaManager.scala:111)
> at
> kafka.server.KafkaApis.kafka$server$KafkaApis$$sendResponseCallback$2(KafkaApis.scala:353)
> at
> kafka.server.KafkaApis$$anonfun$handleProducerRequest$1.apply(KafkaApis.scala:371)
> at
> kafka.server.KafkaApis$$anonfun$handleProducerRequest$1.apply(KafkaApis.scala:371)
> at
> kafka.server.ReplicaManager.appendMessages(ReplicaManager.scala:348)
> at kafka.server.KafkaApis.handleProducerRequest(KafkaApis.scala:366)
> at kafka.server.KafkaApis.handle(KafkaApis.scala:68)
> at
> kafka.server.KafkaRequestHandler.run(KafkaRequestHandler.scala:60)
> at java.lang.Thread.run(Thread.java:745)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
