[ 
https://issues.apache.org/jira/browse/KAFKA-3235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146726#comment-15146726
 ] 

ASF GitHub Bot commented on KAFKA-3235:
---------------------------------------

GitHub user kichristensen opened a pull request:

    https://github.com/apache/kafka/pull/914

    KAFKA-3235: Unclosed stream in AppInfoParser static block

    Always close the stream

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kichristensen/kafka KAFKA-3235

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/914.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #914
    
----
commit 190f62aa659b13a74695118dbb9528679f58b578
Author: Kim Christensen <k...@mvno.dk>
Date:   2016-02-14T20:55:13Z

    Close stream

----


> Unclosed stream in AppInfoParser static block
> ---------------------------------------------
>
>                 Key: KAFKA-3235
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3235
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>             Fix For: 0.9.1.0
>
>
> {code}
>     static {
>         try {
>             Properties props = new Properties();
>             
> props.load(AppInfoParser.class.getResourceAsStream("/kafka/kafka-version.properties"));
>             version = props.getProperty("version", version).trim();
>             commitId = props.getProperty("commitId", commitId).trim();
> {code}
> The stream returned by getResourceAsStream() should be closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to