[ 
https://issues.apache.org/jira/browse/KAFKA-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170172#comment-15170172
 ] 

ASF GitHub Bot commented on KAFKA-3299:
---------------------------------------

GitHub user gwenshap opened a pull request:

    https://github.com/apache/kafka/pull/981

    KAFKA-3299: Ensure that reading config log on rebalance doesn't hang the 
herder

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gwenshap/kafka KAFKA-3299

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/981.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #981
    
----
commit 319672d563f31fb7df85645fd802acc4e1151f75
Author: Gwen Shapira <csh...@gmail.com>
Date:   2016-02-27T00:07:38Z

    Ensure that reading config log on rebalance doesn't hang the herder

----


> KafkaConnect: DistributedHerder shouldn't wait forever to read configs after 
> rebalance
> --------------------------------------------------------------------------------------
>
>                 Key: KAFKA-3299
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3299
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Gwen Shapira
>
> Right now, the handleRebalance code calls readConfigToEnd with timeout of 
> MAX_INT if it isn't the leader.
> The normal workerSyncTimeoutMs is probably sufficient.
> At least this allows a worker to time-out, get back to the tick() loop and 
> check the "stopping" flag to see if it should shut down, to prevent it from 
> hanging forever.
> It doesn't resolve the question of what we should do with a worker that 
> repeatedly fails to read configuration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to