[
https://issues.apache.org/jira/browse/KAFKA-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172880#comment-15172880
]
ASF GitHub Bot commented on KAFKA-3307:
---------------------------------------
GitHub user SinghAsDev reopened a pull request:
https://github.com/apache/kafka/pull/986
KAFKA-3307: Add ProtocolVersion request/response and server side handling.
The patch does the following.
1. For unknown requests or protocol versions, broker sends an empty
response, instead of simple closing the connection.
2. Adds ProtocolVersion request and response, and server side
implementation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SinghAsDev/kafka KAFKA-3307
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/986.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #986
----
commit 3765aa58300f5ffc6997cad22e86ad90f383129e
Author: Ashish Singh <asi...@cloudera.com>
Date: 2016-02-29T00:42:36Z
Init patch. Add req/resp. Add req handling. Add basic ut.
commit e4465910e94cf3300589f94aeeafe55c0ff7ed3e
Author: Ashish Singh <asi...@cloudera.com>
Date: 2016-02-29T04:23:52Z
Respond with empty response body for invalid requests
commit 2985d6dad7241092c8fe9170d56e85f621d8fa1b
Author: Ashish Singh <asi...@cloudera.com>
Date: 2016-02-29T04:28:40Z
Remove commented code
commit 3f103945afee264a9a5d663c6a8048e1388896ad
Author: Ashish Singh <asi...@cloudera.com>
Date: 2016-02-29T22:14:28Z
Add mechanism to deprecate a protocol version. Populate ProtocolVersion's
apiDeprecatedVersions using this mechanism.
----
> Add ProtocolVersion request/response and server side handling.
> --------------------------------------------------------------
>
> Key: KAFKA-3307
> URL: https://issues.apache.org/jira/browse/KAFKA-3307
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Ashish K Singh
> Assignee: Ashish K Singh
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
