[ 
https://issues.apache.org/jira/browse/KAFKA-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180418#comment-15180418
 ] 

ASF GitHub Bot commented on KAFKA-3331:
---------------------------------------

GitHub user SinghAsDev opened a pull request:

    https://github.com/apache/kafka/pull/1014

    KAFKA-3331: Refactor TopicCommand to make describeTopic testable and …

    …add unit tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SinghAsDev/kafka KAFKA-3331

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1014.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1014
    
----
commit 835a54c5abffcfb31949a876cbcddeb077141c15
Author: Ashish Singh <asi...@cloudera.com>
Date:   2016-03-04T19:34:21Z

    KAFKA-3331: Refactor TopicCommand to make describeTopic testable and add 
unit tests.

----


> Refactor TopicCommand to make it testable and add unit tests
> ------------------------------------------------------------
>
>                 Key: KAFKA-3331
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3331
>             Project: Kafka
>          Issue Type: Wish
>            Reporter: Ashish K Singh
>            Assignee: Ashish K Singh
>
> TopicCommand has become a functionality packed, hard to read, class. Adding 
> or changing it with confidence requires some unit tests around it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to