[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193917#comment-15193917
]
ASF GitHub Bot commented on KAFKA-2120:
---------------------------------------
GitHub user christian-posta opened a pull request:
https://github.com/apache/kafka/pull/1061
TRIVIAL: remove TODO in ConsumerNetworkClient after KAFKA-2120
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/christian-posta/kafka
ceposta-trivial-remove-todo-after-KAFKA-2120
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1061.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1061
----
commit e5baf7cae7028c3840195328111fd45b4a403616
Author: Christian Posta <[email protected]>
Date: 2016-03-14T19:03:46Z
TRIVIAL: remove TODO in ConsumerNetworkClient after KAFKA-2120
----
> Add a request timeout to NetworkClient
> --------------------------------------
>
> Key: KAFKA-2120
> URL: https://issues.apache.org/jira/browse/KAFKA-2120
> Project: Kafka
> Issue Type: New Feature
> Reporter: Jiangjie Qin
> Assignee: Mayuresh Gharat
> Priority: Blocker
> Fix For: 0.9.0.0
>
> Attachments: KAFKA-2120.patch, KAFKA-2120_2015-07-27_15:31:19.patch,
> KAFKA-2120_2015-07-29_15:57:02.patch, KAFKA-2120_2015-08-10_19:55:18.patch,
> KAFKA-2120_2015-08-12_10:59:09.patch, KAFKA-2120_2015-09-03_15:12:02.patch,
> KAFKA-2120_2015-09-04_17:49:01.patch, KAFKA-2120_2015-09-09_16:45:44.patch,
> KAFKA-2120_2015-09-09_18:56:18.patch, KAFKA-2120_2015-09-10_21:38:55.patch,
> KAFKA-2120_2015-09-11_14:54:15.patch, KAFKA-2120_2015-09-15_18:57:20.patch,
> KAFKA-2120_2015-09-18_19:27:48.patch, KAFKA-2120_2015-09-28_16:13:02.patch
>
>
> Currently NetworkClient does not have a timeout setting for requests. So if
> no response is received for a request due to reasons such as broker is down,
> the request will never be completed.
> Request timeout will also be used as implicit timeout for some methods such
> as KafkaProducer.flush() and kafkaProducer.close().
> KIP-19 is created for this public interface change.
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-19+-+Add+a+request+timeout+to+NetworkClient
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
