[ https://issues.apache.org/jira/browse/KAFKA-3383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200965#comment-15200965 ]
ASF GitHub Bot commented on KAFKA-3383: --------------------------------------- GitHub user zhuchen1018 reopened a pull request: https://github.com/apache/kafka/pull/1050 KAFKA-3383: remove in flight request only after response parsing succeeds @becketqin, could you take a look at the patch? You can merge this pull request into a Git repository by running: $ git pull https://github.com/zhuchen1018/kafka KAFKA-3383 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1050.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1050 ---- commit 84372bbe06bd121e758348b54d2d79d5fb4fd095 Author: Chen Zhu <amandazhu19620...@gmail.com> Date: 2016-03-11T03:43:52Z KAFKA-3383: remove in flight request only after response parsing succeeds ---- > Producer should not remove an in flight request before successfully parsing > the response. > ----------------------------------------------------------------------------------------- > > Key: KAFKA-3383 > URL: https://issues.apache.org/jira/browse/KAFKA-3383 > Project: Kafka > Issue Type: Bug > Affects Versions: 0.9.0.0 > Reporter: Jiangjie Qin > Assignee: chen zhu > Priority: Critical > Fix For: 0.10.0.0 > > > In the NetworkClient, we remove the in flight request before we successfully > parse the response. If the response parse failed, the request will not be > fulfilled but just lost. For a producer request, that means the callback of > the messages won't be fired forever. > We should only remove the in flight request after response parsing succeeds. -- This message was sent by Atlassian JIRA (v6.3.4#6332)