GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/1088

    KAFKA-3414; Return of MetadataCache.getAliveBrokers should not be mutated 
by cache updates

    `Map.values` returns `DefaultValuesIterable` where the default 
implementation of `toSeq` is (sadly) `toStream`. `Stream` is a lazy collection 
and it can reflect changes to the underlying map before it's `forced`.
    
    I verified that the test failed before my change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka 
kafka-3414-get-alive-brokers-no-mutation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1088.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1088
    
----
commit 00a36ab3d6be92f3cb8c6457ee26f8b64dfcde96
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2016-03-17T12:39:02Z

    Return of MetadataCache.getAliveBrokers should not be mutated by cache 
updates

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to