[ 
https://issues.apache.org/jira/browse/KAFKA-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209485#comment-15209485
 ] 

ASF GitHub Bot commented on KAFKA-3427:
---------------------------------------

GitHub user auradkar opened a pull request:

    https://github.com/apache/kafka/pull/1128

    KAFKA-3427 - Broker should return correct version of FetchResponse on 
exception

    Merging the fix from: https://issues.apache.org/jira/browse/KAFKA-3427
    The original version of the code, returned a response using V0 of the 
response protocol. This caused clients to break because they expected the 
throttle_time_ms field to be present.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/auradkar/kafka k-34

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1128
    
----
commit e1e3cf7ce20e1f0b58e602b48d8b974a64f60cd8
Author: Aditya Auradkar <aaurad...@linkedin.com>
Date:   2016-03-24T00:15:56Z

    KAFKA-3427: Broker should return correct version of fetch response on 
exception
    Merging fix from trunk.

----


> broker can return incorrect version of fetch response when the broker hits an 
> unknown exception
> -----------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-3427
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3427
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.9.0.1, 0.10.0.0
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>            Priority: Blocker
>             Fix For: 0.10.0.0
>
>
> In FetchResponse.handleError(), we generate FetchResponse like the following, 
> which always defaults to version 0 of the response. 
>     FetchResponse(correlationId, fetchResponsePartitionData)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to