[
https://issues.apache.org/jira/browse/KAFKA-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224741#comment-15224741
]
Jay Kreps edited comment on KAFKA-3499 at 4/4/16 6:27 PM:
----------------------------------------------------------
I think this problem is more general than byte[] since lots of things don't
implement equals/hc. A couple of other options:
1. Just document it, this, after all, is how Java handles it.
2. Do a one-time check and throw an error if they haven't overridden hc/equals,
something like
{code}
if(firstExecution) {
checkOverridesEqualsAndHC(key);
firstExecution = false;
}
{code}
was (Author: jkreps):
I think this problem is more general than byte[] since lots of things don't
implement equals/hc. A couple of other options:
1. Just document it, this, after all, is how Java handles it.
2. Do a one-time check, something like
{code}
if(firstExecution) {
checkOverridesEqualsAndHC(key);
firstExecution = false;
}
{code}
> byte[] should not be used as Map key nor Set member
> ---------------------------------------------------
>
> Key: KAFKA-3499
> URL: https://issues.apache.org/jira/browse/KAFKA-3499
> Project: Kafka
> Issue Type: Bug
> Components: kafka streams
> Reporter: josh gruenberg
> Fix For: 0.10.0.0
>
>
> On the JVM, Array.equals and Array.hashCode do not incorporate array
> contents; they inherit Object.equals/hashCode. This implies that Collections
> that rely upon equals/hashCode (eg, HashMap/HashSet and variants) treat two
> arrays with equal contents as distinct elements.
> Many of the Kafka Streams internal classes currently use generic HashMaps and
> Sets to manage caches and invalidation status. For example,
> RocksDBStore.cacheDirtyKeys is a HashSet<K>. Then, in RocksDBWindowStore, the
> Elements are constructed as RocksDBStore<byte[], byte[]>.
> Similarly, the MemoryLRUCache<K, RocksDBCacheEntry> internally holds a
> LinkedHashMap<K,V> map, and a HashSet<K> keys, and these end up holding
> byte[] keys. Finally, user-code may attempt to use any of these provided
> types with byte[], with undesirable results.
> Keys that are byte-arrays should be wrapped in a type that incorporates the
> content in their computation of equals/hashCode. java.nio.ByteBuffer is one
> such type that could be used, but a purpose-built immutable class would
> likely be a better solution.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
