[
https://issues.apache.org/jira/browse/KAFKA-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232691#comment-15232691
]
ASF GitHub Bot commented on KAFKA-3533:
---------------------------------------
GitHub user rnpridgeon opened a pull request:
https://github.com/apache/kafka/pull/1205
KAFKA-3533: Incorrect logic
Incorrect logic in Config Validation for KafkaConsumer.
https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L556-L557
From what I can tell the error message is correct and the logic is not.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rnpridgeon/kafka KAFKA-3533
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1205.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1205
----
commit a90723c31a3757bb5bdf32278242cf7c3c677aa7
Author: Ryan P <ryan.n.pridg...@gmail.com>
Date: 2016-04-08T18:18:44Z
KAFKA-3533:
Incorrect logic in Config Validation
----
> Kafka Consumer Config validation should be AND not OR
> -----------------------------------------------------
>
> Key: KAFKA-3533
> URL: https://issues.apache.org/jira/browse/KAFKA-3533
> Project: Kafka
> Issue Type: Bug
> Reporter: Ryan P
> Labels: Newbie
>
> There seems to be a bit of an inconsistency between between the configuration
> validation imposed in the KafkaConsumer class and the error message presented:
> https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L556-L557
> Based on the error message the request timeout should be greater than the
> session timeout and the max fetch wait timeout. The validation logic however
> checks to ensure that either operand is true, not both.
> In the event that your request timeout is greater than the session timeout
> the operation will be short-circuited allowing for a potential
> misconfiguration of the consumer.
> Based on what I can tell the error message is correct and the validation
> check is incorrect.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
