[
https://issues.apache.org/jira/browse/KAFKA-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249727#comment-15249727
]
ASF GitHub Bot commented on KAFKA-3591:
---------------------------------------
GitHub user QwertyManiac opened a pull request:
https://github.com/apache/kafka/pull/1241
KAFKA-3591: JmxTool should exit out if a provided query matches no values.
Testing: I did manual tests by building locally and running the class
against a remote 0.9.0.0 broker JMX URL. Running with a bad object-name
produces the exit condition, and running with a good one continues to behave as
before (prints the values). Running with no object name dumps all the metrics
(KAFKA-2278).
Docs: This should need no doc changes.
This contribution is my original work and I license the work to the project
under the project's open source license.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/QwertyManiac/kafka trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1241.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1241
----
commit 2d488462d86e9705dfa7cce61c5f68162f2b7d18
Author: Harsh J <ha...@cloudera.com>
Date: 2016-04-20T12:00:59Z
KAFKA-3591: JmxTool should exit out if a provided query matches no values
----
> JmxTool should exit out if a provided query matches no values
> -------------------------------------------------------------
>
> Key: KAFKA-3591
> URL: https://issues.apache.org/jira/browse/KAFKA-3591
> Project: Kafka
> Issue Type: Improvement
> Components: tools
> Affects Versions: 0.9.0.0
> Reporter: Harsh J
> Priority: Trivial
>
> Running {{kafka.tools.JmxTool}} with an invalid query, such as
> {{--object-name "foobar"}} would produce just "time" field outputs given no
> such object. If there are no matched objects when a query has been explicitly
> provided, it should exit out instead of just printing the time data.
> (We should not exit if no filter is provided though, i.e. if the KAFKA-2278
> feature is used)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
