[ 
https://issues.apache.org/jira/browse/KAFKA-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269937#comment-15269937
 ] 

Mayuresh Gharat commented on KAFKA-3651:
----------------------------------------

[~amandazhu19620...@gmail.com] did you intend to open a PR against this jira?

> Whenever the BufferPool throws a "Failed to allocate memory within the 
> configured max blocking time" exception, it should also remove the condition 
> object from the waiters deque
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-3651
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3651
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Mayuresh Gharat
>            Assignee: Mayuresh Gharat
>             Fix For: 0.10.0.0
>
>
> "this.waiters.remove(moreMemory);" should happen before the exception
> is thrown.
> .Otherwise the waiting thread count will never get to 0 after the exception
> and batching will not occur. This is because in the RecordAccumulator.ready
> method the exhausted is set as
> boolean exhausted = this.free.queued() > 0 where free.queued() returns the
> waiters.size().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to