[ https://issues.apache.org/jira/browse/KAFKA-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272234#comment-15272234 ]
Flavio Junqueira commented on KAFKA-3525: ----------------------------------------- I'm a bit confused by what this issue is trying to accomplish. The documentation for {{reserved.broker.max.id}} says "Max number that can be used for a broker.id", which in my interpretation says that the maximum id is the value of {{reserved.broker.max.id}}, and not that there are {{reserved.broker.max.id}} possible values reserved. Unless I'm missing something, the code is correct without the change proposed in the PR, but please clarify if I'm missing the point. > max.reserved.broker.id off-by-one error > --------------------------------------- > > Key: KAFKA-3525 > URL: https://issues.apache.org/jira/browse/KAFKA-3525 > Project: Kafka > Issue Type: Bug > Components: config > Reporter: Alan Braithwaite > Assignee: Manikumar Reddy > Fix For: 0.10.1.0 > > > There's an off-by-one error in the config check / id generation for > max.reserved.broker.id setting. The auto-generation will generate > max.reserved.broker.id as the initial broker id as it's currently written. > Not sure what the consequences of this are if there's already a broker with > that id as I didn't test that behavior. > This can return 0 + max.reserved.broker.id: > https://github.com/apache/kafka/blob/8dbd688b1617968329087317fa6bde8b8df0392e/core/src/main/scala/kafka/utils/ZkUtils.scala#L213-L215 > However, this does a <= check, which is inclusive of max.reserved.broker.id: > https://github.com/apache/kafka/blob/8dbd688b1617968329087317fa6bde8b8df0392e/core/src/main/scala/kafka/server/KafkaConfig.scala#L984-L986 -- This message was sent by Atlassian JIRA (v6.3.4#6332)