[ 
https://issues.apache.org/jira/browse/KAFKA-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274984#comment-15274984
 ] 

ASF GitHub Bot commented on KAFKA-3312:
---------------------------------------

Github user vahidhashemian closed the pull request at:

    https://github.com/apache/kafka/pull/1025


> Add a offsets methods to ZkUtils and replace relevant usages
> ------------------------------------------------------------
>
>                 Key: KAFKA-3312
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3312
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Grant Henke
>            Assignee: Vahid Hashemian
>
> There are many places in the code that manually build a zookeeper path and 
> get or update offsets. Moving this logic to a common location in ZkUtils 
> would be nice. 
> Ex:
> {code}
> zkUtils.readDataMaybeNull(s"${topicDirs.consumerOffsetDir}/${topicPartition.partition}")._1
> {code}
> {code}
>  zkUtils.readData(topicDirs.consumerOffsetDir + "/" + 
> topicAndPartition.partition)._1.toLong
> {code}
> {code}
> zkUtils.updatePersistentPath(s"${topicDirs.consumerOffsetDir}/${topicPartition.partition}",
>  partitionData.offset.toString)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to