[ 
https://issues.apache.org/jira/browse/KAFKA-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315698#comment-15315698
 ] 

Ewen Cheslack-Postava commented on KAFKA-3786:
----------------------------------------------

[~guozhang] Exactly which warnings are you referring to? The code is supposed 
to be trying to track which properties are used -- whether by the parent 
AbstractConfig or anything that gets passed its originals. It does that by 
returning a {{RecordingMap}} when you get the original configs, and then 
{{logUnused}} should not be invoked until you've passed {{originals}} or some 
derivative to all child configurable classes (like serializers).

I think we may not handle the case of both a parent and child using 
{{ConfigDef}}/{{AbstractConfig}}. I think for the child {{AbstractConfig}}, we 
may not compute unused keys properly since it has no idea it is being passed a 
{{RecordingMap}}. Is that the case you're intending to solve here?

> Avoid unused property from parent configs causing WARN entries
> --------------------------------------------------------------
>
>                 Key: KAFKA-3786
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3786
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Guozhang Wang
>            Assignee: Guozhang Wang
>
> Currently the {{AbstractConfig}}'s constructor accepts the passed property 
> map as well as the {{ConfigDef}}, and maintains the original map as well as 
> the parsed values together. Because of it, with hierarchical config passing 
> like {{StreamsConfig}}, the underlying configs will takes all the key-value 
> pairs when constructed and hence cause WARNING log output.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to