[ https://issues.apache.org/jira/browse/KAFKA-2394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316992#comment-15316992 ]
Dustin Cote commented on KAFKA-2394: ------------------------------------ [~ewencp] I only got positive feedback on the change from the mailing list, so sounds like this is a desirable change? > Use RollingFileAppender by default in log4j.properties > ------------------------------------------------------ > > Key: KAFKA-2394 > URL: https://issues.apache.org/jira/browse/KAFKA-2394 > Project: Kafka > Issue Type: Bug > Reporter: Jason Gustafson > Assignee: Dustin Cote > Priority: Minor > Labels: newbie > Attachments: log4j.properties.patch > > > The default log4j.properties bundled with Kafka uses ConsoleAppender and > DailyRollingFileAppender, which offer no protection to users from spammy > logging. In extreme cases (such as when issues like KAFKA-1461 are > encountered), the logs can exhaust the local disk space. This could be a > problem for Kafka adoption since new users are less likely to adjust the > logging properties themselves, and are more likely to have configuration > problems which result in log spam. > To fix this, we can use RollingFileAppender, which offers two settings for > controlling the maximum space that log files will use. > maxBackupIndex: how many backup files to retain > maxFileSize: the max size of each log file > One question is whether this change is a compatibility concern? The backup > strategy and filenames used by RollingFileAppender are different from those > used by DailyRollingFileAppender, so any tools which depend on the old format > will break. If we think this is a serious problem, one solution would be to > provide two versions of log4j.properties and add a flag to enable the new > one. Another solution would be to include the RollingFileAppender > configuration in the default log4j.properties, but commented out. -- This message was sent by Atlassian JIRA (v6.3.4#6332)