[
https://issues.apache.org/jira/browse/KAFKA-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353509#comment-15353509
]
ASF GitHub Bot commented on KAFKA-3761:
---------------------------------------
GitHub user theduderog reopened a pull request:
https://github.com/apache/kafka/pull/1437
KAFKA-3761: Remove BrokerState "RunningAsController"
The reasons to remove it are:
1. It's currently broken. The purpose of the
[JIRA](https://issues.apache.org/jira/browse/KAFKA-3761) was to report that the
RunningAsController state gets overwritten back to "RunningAsBroker".
2. It's not a useful state.
a. If clients want to use this metric to know whether a broker is ready
to receive requests or not, they do not care whether or not the broker is the
controller
b. there is already a separate boolean property, KafkaController.isActive
which contains this information.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/theduderog/kafka KAFKA-3761-broker-state
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1437.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1437
----
commit c0201c5ab8125ea885ff52b234d235d288cd86fb
Author: Roger Hoover <[email protected]>
Date: 2016-06-23T21:52:32Z
Removed RunningAsController state
commit cefead1bed0f0699908bc2819535be4a8f046fd4
Author: Roger Hoover <[email protected]>
Date: 2016-06-23T22:15:30Z
Better formatting for ASCII art
commit 974ba7d4a27dd5ac6b43bc888ece5170737614c5
Author: Roger Hoover <[email protected]>
Date: 2016-06-24T18:26:40Z
Added upgrade note
commit 887fbc0aca264178bb4428b1fdb98dcbe8f2ffdd
Author: Roger Hoover <[email protected]>
Date: 2016-06-24T20:18:17Z
Updated upgrade note based on @ijuma's feedback
commit 5db6479970472fdc8366c17b1cad66971e542a48
Author: Roger Hoover <[email protected]>
Date: 2016-06-24T21:38:43Z
Moved 0.10.1.0 section to the top
----
> Controller has RunningAsBroker instead of RunningAsController state
> -------------------------------------------------------------------
>
> Key: KAFKA-3761
> URL: https://issues.apache.org/jira/browse/KAFKA-3761
> Project: Kafka
> Issue Type: Bug
> Reporter: Ismael Juma
> Assignee: Roger Hoover
>
> In `KafkaServer.start`, we start `KafkaController`:
> {code}
> /* start kafka controller */
> kafkaController = new KafkaController(config, zkUtils, brokerState,
> kafkaMetricsTime, metrics, threadNamePrefix)
> kafkaController.startup()
> {code}
> Which sets the state to `RunningAsController` in
> `KafkaController.onControllerFailover`:
> `brokerState.newState(RunningAsController)`
> And this later gets set to `RunningAsBroker`.
> This doesn't match the diagram in `BrokerStates`. [~junrao] suggested that we
> should start the controller after we register the broker in ZK, but this
> seems tricky as we need to controller in `KafkaApis`.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
