[
https://issues.apache.org/jira/browse/KAFKA-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369019#comment-15369019
]
ASF GitHub Bot commented on KAFKA-3942:
---------------------------------------
GitHub user dguy opened a pull request:
https://github.com/apache/kafka/pull/1600
KAFKA-3942: Change IntegrationTestUtils.purgeLocalStreamsState to use
java.io.tmpdir
It was previously only deleting files/folders where the path started with
/tmp. Changed it to delete from the value of the System Property
`java.io.tmpdir`. Also changed the tests that were creating State dirs under
/tmp to just use `TestUtils.tempDirectory(..)`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dguy/kafka kafka-3942
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1600.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1600
----
commit 8e68f12f9e0c9b1c67fc5ffb4c33cf1b6a65cc4f
Author: Damian Guy <[email protected]>
Date: 2016-07-09T09:00:49Z
Change IntegrationTestUtils.purgeLocalStreamsState to use java.io.tmpdir
----
> Change IntegrationTestUtils.purgeLocalStreamsState to use java.io.tmpdir
> ------------------------------------------------------------------------
>
> Key: KAFKA-3942
> URL: https://issues.apache.org/jira/browse/KAFKA-3942
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Affects Versions: 0.10.1.0
> Reporter: Damian Guy
> Assignee: Damian Guy
> Priority: Trivial
> Fix For: 0.10.1.0
>
>
> {code}IntegrationTestUtils.purgeLocalStreamsState(...){code} currently only
> removes the folders if the path starts with /tmp. This should really use
> {code}System.getProperty("java.io.tmpdir"){code}
> Once this has been changed the tests using it should be able to simplify
> their {code}StreamsConfig.STATE_DIR_CONFIG{code} to
> {code}TestUtils.tempDirectory().getPath(){code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
