[ https://issues.apache.org/jira/browse/KAFKA-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400176#comment-15400176 ]
ASF GitHub Bot commented on KAFKA-3946: --------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/1680 > Protocol guide should say that Produce request acks can only be 0, 1, or -1 > --------------------------------------------------------------------------- > > Key: KAFKA-3946 > URL: https://issues.apache.org/jira/browse/KAFKA-3946 > Project: Kafka > Issue Type: Bug > Reporter: James Cheng > Assignee: Mickael Maison > Priority: Minor > Fix For: 0.10.1.0 > > > The protocol guide at http://kafka.apache.org/protocol.html#protocol_messages > says that for Produce requests, acks means: > The number of nodes that should replicate the produce before returning. -1 > indicates the full ISR. > This seems to imply that you can specify values of 2,3,4, etc. > It would be clearer if the description was more explicit. It should say that > the only valid values are 0, 1, and -1, per the code at > https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/ReplicaManager.scala#L382-L384 -- This message was sent by Atlassian JIRA (v6.3.4#6332)