GitHub user antonnazaruk opened a pull request:
https://github.com/apache/kafka/pull/1689
HOTFIX: Fix punctuation timestamp in PunctuationQueue.java
Actually, there are two problems:
1) Processor's "punctuate" method is not calling if there are NO new
messages in "source" topic
2) When message comes after let's say 20 seconds delay (punctuation timeout
was set to 2 seconds) - method punctuate is calling 10 times in a loop for
every "missed" call within delayed period with the SAME timestamp
Actually suggested change only fixes second item (every missed call will be
using it's timestamp). Can anyone, please, comment if first item's statement is
intended behavior or a bug?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/antonnazaruk/kafka patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1689.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1689
----
commit 900cc7f8d6ff893fcc30ec8ce5bb01cb6903c189
Author: antonnazaruk <[email protected]>
Date: 2016-07-30T21:15:46Z
Fix punctuation timestamp in PunctuationQueue.java
Actually, there are two problems:
1) Processor's "punctuate" method is not calling if there are new messages
in "source" topic
2) When message comes after let's say 20 seconds delay (punctuation timeout
was set to 2 seconds) - method punctuate is calling 10 times in a loop for
every "missed" call within delayed period with the SAME timestamp (what doesn't
have sense to me),
Actually suggested change only fixes second item (every missed call will be
using it's timestamp). Can anyone, please, comment if first item's statement is
intended behavior or a bug?
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
