[
https://issues.apache.org/jira/browse/KAFKA-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412571#comment-15412571
]
ASF GitHub Bot commented on KAFKA-4011:
---------------------------------------
GitHub user radai-rosenblatt opened a pull request:
https://github.com/apache/kafka/pull/1714
KAFKA-4011 - fix issues and beef up tests around ByteBoundedBlockingQueue
as discussed under KIP-72
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radai-rosenblatt/kafka
ByteBoundedBlockingQueue-work
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1714.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1714
----
commit d5a63e5fe818587a582fce77bd622422d404afc2
Author: radai-rosenblatt <[email protected]>
Date: 2016-08-08T21:59:24Z
KAFKA-4011 - fix issues and beef up tests around ByteBoundedBlockingQueue,
as discussed under KIP-72
----
> allow sizing RequestQueue in bytes
> ----------------------------------
>
> Key: KAFKA-4011
> URL: https://issues.apache.org/jira/browse/KAFKA-4011
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.10.0.0
> Reporter: radai rosenblatt
> Fix For: 0.10.1.0
>
>
> currently RequestChannel's requestQueue is sized in number of requests:
> {code:title=RequestChannel.scala|borderStyle=solid}
> private val requestQueue = new
> ArrayBlockingQueue[RequestChannel.Request](queueSize)
> {code}
> under the assumption that the end goal is a bound on server memory
> consumption, this requires the admin to know the avg request size.
> I would like to propose sizing the requestQueue not by number of requests,
> but by their accumulated size (Request.buffer.capacity). this would probably
> make configuring and sizing an instance easier.
> there would need to be a new configuration setting for this
> (queued.max.bytes?) - which could be either in addition to or instead of the
> current queued.max.requests setting
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
