[ 
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446621#comment-15446621
 ] 

ASF GitHub Bot commented on KAFKA-3940:
---------------------------------------

GitHub user imandhan reopened a pull request:

    https://github.com/apache/kafka/pull/1787

    KAFKA-3940 Log should check the return value of dir.mkdirs()

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/imandhan/kafka KAFKA-3940

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1787.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1787
    
----
commit e3f5f293104013da3aa765c9ba7cbdb2553f6485
Author: Ishita Mandhan <iman...@us.ibm.com>
Date:   2016-08-25T21:38:16Z

    KAFKA-3940 Log should check the return value of dir.mkdirs()

----


> Log should check the return value of dir.mkdirs()
> -------------------------------------------------
>
>                 Key: KAFKA-3940
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3940
>             Project: Kafka
>          Issue Type: Bug
>          Components: log
>    Affects Versions: 0.10.0.0
>            Reporter: Jun Rao
>            Assignee: Ishita Mandhan
>              Labels: newbie
>
> In Log.loadSegments(), we call dir.mkdirs() w/o checking the return value and 
> just assume the directory will exist after the call. However, if the 
> directory can't be created (e.g. due to no space), we will hit 
> NullPointerException in the next statement, which will be confusing.
>    for(file <- dir.listFiles if file.isFile) {



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to