+1 (binding) I think the major gap I notice in the PR is a lack of docs updates to notify people of the change. Given these are improvements and streams is still new, I wouldn't necessarily call them out as anything critical, but the changes should be noted somewhere.
-Ewen On Tue, Aug 30, 2016 at 3:53 PM, Guozhang Wang <wangg...@gmail.com> wrote: > +1 (binding) > > Thanks! > > On Tue, Aug 30, 2016 at 2:42 AM, Damian Guy <damian....@gmail.com> wrote: > > > +1 > > > > On Mon, 29 Aug 2016 at 18:07 Eno Thereska <eno.there...@gmail.com> > wrote: > > > > > +1 (non-binding) > > > > > > > On 29 Aug 2016, at 12:22, Bill Bejeck <bbej...@gmail.com> wrote: > > > > > > > > +1 > > > > > > > > On Mon, Aug 29, 2016 at 5:50 AM, Matthias J. Sax < > > matth...@confluent.io> > > > > wrote: > > > > > > > >> I’d like to initiate the voting process for KIP-77: > > > >> > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > >> 77%3A+Improve+Kafka+Streams+Join+Semantics > > > >> > > > >> -Matthias > > > >> > > > >> > > > >> > > > > > > > > > > > > -- > -- Guozhang > -- Thanks, Ewen
