[
https://issues.apache.org/jira/browse/KAFKA-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478602#comment-15478602
]
ASF GitHub Bot commented on KAFKA-4145:
---------------------------------------
GitHub user vahidhashemian opened a pull request:
https://github.com/apache/kafka/pull/1842
KAFKA-4145: Avoid redundant integration testing in ProducerSendTests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vahidhashemian/kafka KAFKA-4145
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1842.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1842
----
commit 101ab22d130c9b03ca914edd14f41ada2e7f374b
Author: Vahid Hashemian <[email protected]>
Date: 2016-09-09T20:43:50Z
KAFKA-4145: Avoid redundant integration testing in ProducerSendTests
----
> Avoid redundant integration testing in ProducerSendTests
> --------------------------------------------------------
>
> Key: KAFKA-4145
> URL: https://issues.apache.org/jira/browse/KAFKA-4145
> Project: Kafka
> Issue Type: Improvement
> Components: unit tests
> Reporter: Jason Gustafson
> Assignee: Vahid Hashemian
>
> We have a few test cases in {{BaseProducerSendTest}} which probably have
> little value being tested for both Plaintext and SSL. We can move them to
> {{PlaintextProducerSendTest}} and save a little bit on the build time. The
> following tests seem like possible candidates:
> 1. testSendCompressedMessageWithCreateTime
> 2. testSendNonCompressedMessageWithCreateTime
> 3. testSendCompressedMessageWithLogAppendTime
> 4. testSendNonCompressedMessageWithLogApendTime
> 5. testAutoCreateTopic
> 6. testFlush
> 7. testSendWithInvalidCreateTime
> 8. testCloseWithZeroTimeoutFromCallerThread
> 9. testCloseWithZeroTimeoutFromSenderThread
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
