[
https://issues.apache.org/jira/browse/KAFKA-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15517913#comment-15517913
]
ASF GitHub Bot commented on KAFKA-4213:
---------------------------------------
GitHub user apurvam opened a pull request:
https://github.com/apache/kafka/pull/1904
KAFKA-4213: First set of system tests for replication throttling, KIP-73.
This patch also fixes the following:
1. KafkaService.verify_reassign_partitions did not check whether
partition reassignment actually completed successfully (KAFKA-4204).
This patch works around those shortcomings so that we get the right
signal from this method.
2. ProduceConsumeValidateTest.annotate_missing_messages would call
`pop' on the list of missing messages, causing downstream methods to get
incomplete data. We fix that in this patch as well.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apurvam/kafka throttling-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1904.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1904
----
commit fe4a0b1070f25e687fb8075210da9c5a356fa1c8
Author: Apurva Mehta <[email protected]>
Date: 2016-09-23T23:41:02Z
Initial commit of system tests for replication throttling, KIP-73.
This patch also fixes the following:
1. KafkaService.verify_reassign_partitions did not check whether
partition reassignment actually completed successfully (KAFKA-4204).
This patch works around those shortcomings so that we get the right
signal from this method.
2. ProduceConsumeValidateTest.annotate_missing_messages would call
`pop' on the list of missing messages, causing downstream methods to get
incomplete data. We fix that in this patch as well.
----
> Add system tests for replication throttling (KIP-73)
> ----------------------------------------------------
>
> Key: KAFKA-4213
> URL: https://issues.apache.org/jira/browse/KAFKA-4213
> Project: Kafka
> Issue Type: Test
> Reporter: Apurva Mehta
> Assignee: Apurva Mehta
>
> Add system tests for replication throttling. The two main things to test are:
> 1. kafka-reassign-partitions: in this use case, a new broker is added to a
> cluster, and we are testing throttling of the partitions being replicated to
> this cluster. The '--throttle' option of the reassign partitions tool is what
> we want to test. we will invoke the tool with this option, and assert that
> the replication takes a minimum amount of time, based on the throttle and the
> amount of data being replicated.
> 2. kafka-configs: in this use case, we lost a broker of an existing cluster
> for whatever reason, and want to re-replicate data to it from some point in
> time. We want this re-replicated data to be throttled. Again, we will check
> that the re-replication took at least a certain amount of time based on the
> value of the throttle and the amount of data being replicated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)